remove other notification actions #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: - it has been quite a while since we only support GlobalActions - this PR removes both the helper methods to turn models into GlobalActions as well as typing references to other models - it might break existing customers using the tuned models, so the next release should communicate this properly - this PR also fixes a bunch of typing issues after running pyright on the repo
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
| @@ -217,7 +180,7 @@ class Monitor(NoExtrasBaseModel): | |||
| regex="[0-9a-zA-Z \\-_]+", | |||
| ) | |||
| tags: Optional[ # type: ignore | |||
| List[constr(min_length=3, max_length=32, regex="[0-9a-zA-Z\\-_]")] # noqa F722 | |||
| List[constr(min_length=3, max_length=32, regex="[0-9a-zA-Z\\-_]")] # type:ignore # noqa: F722 | |||
There was a problem hiding this comment.
You can probably fix the type error here and in analyzer by changing constr to Annotated like I did with monitor schema
There was a problem hiding this comment.
just caught an error by defining analyzerIds to be a str (same as you did for the monitor schema), so I believe we should also update that there!
There was a problem hiding this comment.
Did you try changing the List[constr... on tags? So maybe type:ignore can go away
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
temporarily deployed
to
whylabs-toolkit-ci
GitHub Actions
Inactive
christinedraper
approved these changes
May 29, 2024
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
force-pushed
the
dev/murilommen/fix-remove-other-actions
branch
from
eceb27f
to
bce2ebe
Compare
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
force-pushed
the
dev/murilommen/fix-remove-other-actions
branch
from
bce2ebe
to
404a5fb
Compare
murilommen
temporarily deployed
to
whylabs-toolkit-ci
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details:
GlobalActions